Etheri improvements and fixes#85
Etheri improvements and fixes#85RedHawk989 merged 8 commits intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom
Conversation
In additon resets caibration data for IBO on recalibrate
lorow
left a comment
There was a problem hiding this comment.
looks pretty good to me, nice one! I've only left two open-ended things to discuss whether we should black the code and whether we should expose some more advanced settings for folks to tinker with
| ibo_filter_samples: int = 400 | ||
| ibo_average_output_samples: int = 0 | ||
| ibo_fully_close_eye_threshold: float = 0.3 | ||
| calibration_samples: int = 600 |
There was a problem hiding this comment.
This is a good idea, I think I'll do the same in my own PR. One thing that I'm thinking about is - should we expose some of the fields like the calibration_samples or ibo_filter_samples in advanced settings?
There was a problem hiding this comment.
I think it would be awesome to add them as settings, I just didn't know how! I can look! 😅
There was a problem hiding this comment.
I'd check out how the settings_widget.py is implemented, don't quote on that but I think that's how it all works xD
There was a problem hiding this comment.
I'll set them up as config settings in a commit soon :)
| if os.path.exists(self.imgfile): | ||
| os.remove(self.imgfile) | ||
|
|
||
| def intense(self, x, y, frame,filterSamples,outputSamples): |
There was a problem hiding this comment.
So I've noticed this in a couple of places, it may be worth just straight up running Black over the file we're currently working as an additional step to format the code just to make it a bit cleaner
we should also probably add it as a dev dependency too
https://python-poetry.org/docs/managing-dependencies/
There was a problem hiding this comment.
I like that idea, formatting python doesn't seem very easy!
Adding the eyelids to config and adding an invert bool makes this work with most peoples currently setup eyelids if they used eyetracking before native
|
I had to fix the osc calibration point as I got the wrong settings reference somehow |
|
All looks good now! I'll black format once merged because pycharm is being funky on this PR atm (user error) |
Description
Fixes dual eye tracking
Fixes IBO filter
Fixes numpy type error
Adds optional configurable averaging of IBO output
Adds /avatar/parameters/LeftClosed and /avatar/parameters/RightClosed parametrs to native OSC output for eyelid control
Changes
Reset IBO data on recalibrate
Make IBO filter a config variable
Make calibration samples a config variable
Checklist