Fix issues in existing USB-based eye tracker implementation to enable proper functionality.#80
Merged
RedHawk989 merged 4 commits intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom Apr 9, 2023
Conversation
* fix: remove duplicated requests dep
* fix: existing impl always passed None as the port, it never worked * feat: initial handling of unplugging usb serial device * feat: check if port exists before trying to open it * fix: existing impl caused division by zero when calculating fps * fix: existing impl did not exit when image not found then crashed * fix: warn logs were marked as info
* feat: serial read no longer drops frames on buffer reset * fix: fps now calculated properly * fix: remove unnecessary logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm submitting a pull request to fix the existing implementation of the USB-based eye tracker. Addressed latency issues by discarding the serial buffer - potential impact on framerate. Needs a proper solution soon(tm).
I tested the updated implementation on two ESP32S3 boards and I'm happy to report that the eye tracker is now functioning as expected within the app. Not tested with a virtual reality headset and proper camera placement yet.
Further improvements will follow.