Linux build/runtime fixes#59
Merged
RedHawk989 merged 2 commits intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom Feb 10, 2023
Meister1593:HSF-and-new-algos-feature-branch
Merged
Linux build/runtime fixes#59RedHawk989 merged 2 commits intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom Meister1593:HSF-and-new-algos-feature-branch
RedHawk989 merged 2 commits intoEyeTrackVR:HSF-and-new-algos-feature-branchfrom
Meister1593:HSF-and-new-algos-feature-branch
Conversation
…ows compilation; Added pandas dependency as it was required in clean build for runtime; Added platform specific checks to disable winsound and triggers for it in codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed building and running ETVR on linux, where it couldn't be built because it contained windows only dependency (added platform-specific condition to include it only on windows).
At runtime there was issue when updating numpy past 1.24 version so i decided to lock it to latest 1.23.5 version so it would be updated only when code will be adapted.
And lastly , at runtime there is also issue where some code paths for winsound weren't checked for platform and ran on linux anyway. I think these checks should be replaced with proper platform-agnostic code (library) for handling sounds.
Also updated lock along the way.
I haven't tested it with windows, so prior to merging it almost definitely needs to be checked on clean build.
Checklist