Fix eye recentering via OSC / Avatar menus#131
Merged
lorow merged 1 commit intoEyeTrackVR:v2.0-beta-feature-branchfrom Feb 6, 2025
Merged
Fix eye recentering via OSC / Avatar menus#131lorow merged 1 commit intoEyeTrackVR:v2.0-beta-feature-branchfrom
lorow merged 1 commit intoEyeTrackVR:v2.0-beta-feature-branchfrom
Conversation
lorow
approved these changes
Jan 28, 2025
Member
lorow
left a comment
There was a problem hiding this comment.
No idea how I initially missed the bug with if thing is not bool, nor how I didn't catch it during testing.
It also looks like there's a pretty big difference between my fork and the upstream, hence the confusion over at discord. Looks like recentering initially was implemented: https://github.com/EyeTrackVR/EyeTrackVR/pull/106/files#diff-a70ce7f77fc7ff4c3769e569986ad96398b08a12082e671f0cd7aeed5d2d3f07R510 but somehow got lost?
Nevertheless, thank you very much for narrowing this down and fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes re-centering eyes via OSC from avatar menu.
Sorry if I did anything GitHub wrong, I've never actually done this before :)
Related issue (if applicable): fixes #
Checklist