Fix centering overlay not working#126
Merged
RedHawk989 merged 2 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom Dec 28, 2024
Merged
Fix centering overlay not working#126RedHawk989 merged 2 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
RedHawk989 merged 2 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
Conversation
Collaborator
|
Does os.startfile actually correctly pass the argument now? The reason it was a batch file is that it never seemed to properly pass it for whatever reason. Good news if it works that way now! (I'll review and merge in ~3 weeks when finals are done for me) |
Contributor
|
That's great! |
Contributor
|
You can delete the 2 useless bat files :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Assuming the second point is because the exe hasn't been updated from it's own repo for a while. Can be deleted when it's updated to fix the directory usage from /eyetrackapp to /eyetrackapp/tools/assets
Checklist