Feat: Set timer resolution (1ms)#120
Merged
RedHawk989 merged 3 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom Nov 27, 2024
Merged
Feat: Set timer resolution (1ms)#120RedHawk989 merged 3 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
RedHawk989 merged 3 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
Conversation
8f9adb7 to
f314efd
Compare
f314efd to
fd40ffe
Compare
Collaborator
|
Just a quick note: I'm on hiatus for this month for personal things. I will review your PRs sometime in November. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reasoning frequent use of "time.time()" which could cause unexpected behaviour. For example "camera.py" used to contain:
Line
self.fps = 1 / (self.newft - self.prevft)which triggered "ZeroDivisionError" if loop ran faster than windows default timer resolution.Your current code correctly handles this example, so this isn't an issue anymore but...
TLDR:
Rather than hope that user has a program open that requests a higher timer resolution. Do it ourselves?
Checklist