Fix blinking in native eye tracking being very twitchy#115
Merged
lorow merged 1 commit intoEyeTrackVR:v2.0-beta-feature-branchfrom Jul 5, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for native blinking being twitchy, reported by Raeschen.
In the previous implementation the blinking in dual eye mode was being averaged, in the rewrite we introduced a slight bug where this wasn't accounted for. Instead, we were treating them like separate eyes which lead to "switching" of values and in consequence twitching, I added back averaging
Checklist