Bugfix/v2 params fix#104
Merged
RedHawk989 merged 2 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom Feb 21, 2024
Merged
Conversation
Break: Pytest-cov, there's a workaround
Collaborator
|
looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As encountered by Raeschen, changing the imports to import from EyeTrackVR.* without setting up a PYTHONPATH prior, breaks the makefile.
This change restores the old imports and gets makefile to work again, altho it makes it so
poetry run pytestfails.To get pytest to work again, use
poetry run python -m pytestAdditionally, as discovered by Prohurtz, top level __init__.py breaks pyinstaller's runtime imports. I've removed the file to fix the installer. This now breaks the coverage, but seeing as this is only useful for writing tests and seeing what else we haven't tested yet, it's not that important.
There's a workaround for that, though: pytest-dev/pytest-cov#88
Checklist