Fix: fix v2 params behaving not correctly #103
Merged
RedHawk989 merged 3 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom Feb 12, 2024
Merged
Fix: fix v2 params behaving not correctly #103RedHawk989 merged 3 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
RedHawk989 merged 3 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
Conversation
# TODO test binary blink and outer eye falloff
5ac33d1 to
82e707b
Compare
RedHawk989
approved these changes
Feb 12, 2024
Collaborator
RedHawk989
left a comment
There was a problem hiding this comment.
Loks good. I cant do super in-depth testing but ill fix problems as they come up later if that is the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the Unified Params / V2 Params implementation used with the VRCFT Module. This is not a refactor, just a bugfix. Refactor will come with the implementation of proper module support.
What is being done in this PR:
Black - changed from default80 lines to 120, can be reverted if we don't want that.
Pytest - Added pytest with configuration and basic fixtures and mocks
osc.py - Fixes and black format
any other touched files: fixes encountered while writing tests, simple cleanups and black formats
Won't be done in this PR:
More comprehensive tests will come with osc.py refactor
Checklist
The pull request is done against the latest development branch
Only relevant files were touched
Code change compiles without warnings
The code change is tested and works with EyeTrackVR core ESP32 newest release
I accept the CLA.