Skip to content

Improve UX of rotated crop#100

Merged
RedHawk989 merged 15 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
SafariMonkey:improve-roi-rotation
Jul 10, 2024
Merged

Improve UX of rotated crop#100
RedHawk989 merged 15 commits intoEyeTrackVR:v2.0-beta-feature-branchfrom
SafariMonkey:improve-roi-rotation

Conversation

@SafariMonkey
Copy link
Contributor

Description

  • ROI region is cropped at the same time as rotation, not before, so the crop doesn't cut into the rotated ROI
    • Filling the background is skipped if the crop is entirely within the camera image, and the image is warped with transparency enabled and then filled based on the average colors of non-transparent pixels otherwise.
  • Make ROI widget rotate the image, optionally with padding so the widget stays the same size as it rotates
    • The crop is limited to the axis-aligned bounding box (AABB) of the image corners, to make it easier to not waste any rows or columns.
  • Add a crosshair to the ROI widget (with some slightly sneaky access of the underlying tkinter to set the dashed line property)

Checklist

  • I accept the CLA.

@SafariMonkey SafariMonkey changed the title Improve UX of rotated crop Draft: Improve UX of rotated crop Nov 7, 2023
@SafariMonkey SafariMonkey changed the title Draft: Improve UX of rotated crop Improve UX of rotated crop Nov 8, 2023
@RedHawk989 RedHawk989 self-requested a review November 11, 2023 18:45
@RedHawk989 RedHawk989 merged commit 3a74182 into EyeTrackVR:v2.0-beta-feature-branch Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants