Skip to content

Resolved #4566 where performance was poor for filtering file models by file_name #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomJaeger merged 1 commit into from
Nov 17, 2025
Merged

Resolved #4566 where performance was poor for filtering file models by file_name #5051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions system/ee/ExpressionEngine/Model/File/FileSystemEntity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ class FileSystemEntity extends ContentModel
'beforeInsert',
'beforeSave'
);
protected static $_binary_comparisons = array(
'file_name'
);

protected static $_binary_comparisons = array();

protected static $_hook_id = 'file';

Expand Down Expand Up @@ -120,6 +119,16 @@ class FileSystemEntity extends ContentModel
protected $_subfolderPath;
protected $_exists;

public function __construct() {
parent::__construct();

// If this is a case-sensitive filesystem mark the file_name column
// to be filtered with a binary cast to enforce case-sensitive comparison
if(ee()->config->item('filesystem_case_sensitive') === 'y') {
static::$_binary_comparisons[] = 'file_name';
}
}

/**
* A link back to the owning group object.
*
Expand Down
Loading