-
Notifications
You must be signed in to change notification settings - Fork 130
new php cli script for bumping ee version #5045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bump version... also removed the creation of backup files
build-tools/make_version.php
Outdated
| } | ||
|
|
||
|
|
||
| private function writeFileAtomically($filePath, $content, $originalChecksum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like you're using $originalChecksum. Should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. updated
| define('PATH_CACHE', SYSPATH . 'user/cache/'); | ||
| define('APPPATH', BASEPATH); | ||
| define('APP_VER', '7.5.17'); | ||
| define('APP_VER', '7.5.21'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these version changes be part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
system/ee/legacy/libraries/Core.php
Outdated
| define('APP_BUILD', '20251024'); | ||
| define('APP_VER', '7.5.17'); | ||
| define('APP_BUILD', '20251231'); | ||
| define('APP_VER', '7.5.21'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these version changes be part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
new php cli script for bumping ee version