Fixed a bug in updater where db connection did not include all availa… #5019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryannielsen
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ble attributes
User needs the MYSQL_ATTR_SSL_CA and MYSQL_ATTR_SSL_VERIFY_SERVER_CERT attributes set in order to connect to Azure app db. That works fine, but then updates fail with:
Could not connect to the database using the credentials provided. ee/installer/updater/ExpressionEngine/Updater/Service/Updater/RequirementsChecker.php:65
Poking, and the db connection in the RequirementsChecker.php doesn't include those additional attributes that are in /system/ee/legacy/database/drivers/mysqli/mysqli_connection.php. So I added them. Aside from something about encoding for new tables which didn't seem relevant.
Might be better to abstract and share that stuff, but this is confirmed to work. So I'm going with this.