Fixed a Pro Variable bug where date setting options did not stick #5000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues with saved settings
TomJaeger
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radio settings for the pro variable date field weren't sticking:
The change to the date fieldtype was required because in pro variable we're renaming the date field temporarily to entry_date so it was never showing the localization.
There IS still a bug where if set the localization option when you populate the variable, it's not doing anything. We should either get rid of the option entirely or we need to change things up so we save that data and then use it. Probably go in as pipe delimited or some such. But I'm not sure we want to keep it so making a new bug for discussion and we may just want to ditch that in the settings.