Resolved #3556 where some date fields still could not accommodate dates past year 2038 #4855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJaeger
previously requested changes
Jun 4, 2025
TomJaeger
reviewed
Jun 4, 2025
302b01b to
638a5a7
Compare
Contributor
|
Looks like date picker isn't showing as it should in PHP 8.4 cypress tests so it keeps failing.. we'll have to look into this. |
Contributor
|
So other PR's are failing for same reason.. I think we need to look into why its happening, but it's likely not part of this PR.. merging |
TomJaeger
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #3556 where some date fields still could not accommodate dates past year 2038
Turns out the #3911 PR was incomplete, some of date fields were omitted. This PR is fixing it