Skip to content

Dual band binding happening on wrong rate #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pkendall64 merged 1 commit into from
Dec 15, 2025
Merged

Dual band binding happening on wrong rate #3446

pkendall64 merged 1 commit into from
Dec 15, 2025
+1 −1

Conversation

@CapnBry
Copy link
Member

@CapnBry CapnBry commented Dec 13, 2025 •
edited
Loading

Resolves Team2.4-only RXes not being able to traditional bind with a Dual Band TX, due to the TX being on the wrong packet rate.

The TX actually switches to RATE_MAX which is RATE_LORA_DUAL_100HZ_8CH

wTimer stop
set rate 6
hwTimer interval: 20000
Config LoRa
Adjusted max packet size 64-128
hwTimer resume
Entered binding mode at freq = 915500000
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
e9 1 9 93 80 ce
set rate 21  <--- Wrong index
hwTimer interval: 10000  <-- 100Hz?! 
Config LoRa <-- dual band
Config LoRa <-- dual band
Adjusted max packet size 64-128
9 9 93 80 ce 77  <-- 8ch packet encoding
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77
9 9 93 80 ce 77

Backport

This does NOT need a backport to 3.x as 3.x mixes the references such that the first binding uses enumRatetoIndex(enum) and the second uses a direct index. Although we could backport it to use enums both places if we want to get our PR count up!

mha1
mha1 approved these changes Dec 14, 2025
View reviewed changes
Copy link
Contributor

@mha1 mha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested working on Nomad and ER4/ER6/SuperP

@pkendall64 pkendall64 merged commit 9e0b767 into ExpressLRS:master Dec 15, 2025
26 checks passed
@CapnBry CapnBry mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkendall64 pkendall64 pkendall64 approved these changes

@mha1 mha1 mha1 approved these changes

@deadbytefpv deadbytefpv deadbytefpv approved these changes

Assignees

No one assigned

Labels

bugfixes 🐞 V4.0 🍔

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CapnBry @pkendall64 @mha1 @deadbytefpv