STM32 and 8285 do NOT support two RF paths #3406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused an issue where the PA was NOT enabled when transmitting because we send Radio_ALL which is not supported
mha1
approved these changes
Nov 16, 2025
|
Tested this PR on my GEP 2.4 Nano PA, but refused to bind, so tested PR 3407 (0b7543) then RX bound without problems, but still crappy TRSS! |
Member
|
Wow that's nuts that ESP8285 was coded to work with two independent RF frontends but didn't understand RadioAll-- must be left over from early True Diversity dev? You're right though, all dual frontend stuff is made with ESP32 by requirement so it is better to remove the extra code. Code looks right. BetaFPV Nano RX on 3.6.1:
BetaFPV Nano RX on this:
I've now noticed that of the 10 different things on my desk there is literally 0 hardware that is ESP8285 RX with an amp, so I can see how I never noticed this! |
CapnBry
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some of the refactoring/optimisation had the radio number set to RadioAll, this caused an issue where the PA was NOT enabled when transmitting because the code path on the STM32 and ESP8285 does not actually support 2 radios.
Solution
Remove all the old code that that operated on the second RF AMP, even though it couldn't actually be supported. Now if RadioAll is passed in it handles it as Radio1, which is "All" on STM32 and ESP8285.
This needs to merged to the
masterbranch which will fix #3395