Skip to content

Conversation

@CapnBry
Copy link
Member

@CapnBry CapnBry commented Oct 20, 2025

Fixes debug logging not working during init (options/hardware loading) due to the misnamed compiler define `DEBUG_INIT != LOG_INIT.

While I was messing with the log stuff, I had a few minor things

  • Rename TxBackpack / SerialLogger -> BackpackOrLogStrm. Unify the name between TX and RX so there's less different code between the two and define code to just use a different variable name.
  • Move "Set parameter [%s]=%u" message so it doesn't print out every time the lua polls the TX for the ELRS STATUS type message (parameter 0) every second
  • Remove "ExpressLRS module booted..." that is not even around anything useful and is halfway through the process.
  • Bundle all the FHSS initialization messages into one line for each radio. Remove the FHSS channel dumps; anyone who is saying they're still checking this on every (or any) boot is full of lies!
  • BAD:GOOD packet counter moved to verbose debugging. Another once-a-second message that clogs real debug. I turn this off every time I am debugging, but if this is something everyone wants to keep, I can put it back.
  • The boot-time UID printout uses the incorrect format specifier (signed vs not). It worked fine but since we're in here...

Unrelated

The unit tests were generating a warning about ISO C++ forbids using a literal for a char *, which I believe is just old cruft that never got updated and nobody notices because they don't run the tests locally. I removed the unused definition of product_name and assigned device_name as it is in non-native code.

@pkendall64 pkendall64 added the house keeping 🧹 Cleanup of code and house keeping label Oct 20, 2025
@CapnBry CapnBry merged commit 49249c2 into ExpressLRS:master Oct 24, 2025
25 checks passed
@CapnBry CapnBry deleted the debug-init branch October 25, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

house keeping 🧹 Cleanup of code and house keeping V4.0 🍔

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants