Allow secondary CRSF port to send RC data #3364
Conversation
mha1
left a comment
There was a problem hiding this comment.
CRSF-Tester confirms RC Channel data present if protocol is set to CRSF on either or both serial interfaces.
6fc8fbc to
78431d6
Compare
There was a problem hiding this comment.
I can understand why this design choice was made, but coming to this without having ever used a Serial2 before, it surely defies expectations. I had to run a test setup before the PR just to verify: "Really? You set the Serial2 to CRSF and no channels come out?!". That == true.
After the PR, channels come out both Serials configured which is what I'd expect if I were configuring this. I tested with an ER8 and the VBAT telemetry also comes out both serials as well as goes to the TX which... I'm not sure if that's what is expected from a user perspective but I guess the packet doesn't have a destination so broadcast is appropriate?
Unrelated: It has been 0 days since someone has complained that RM swapped the RX/TX pins on the serial outputs on the ER8. I also could not get the friggin connector back out and had to cut off the tab inside to extract it 😅
|
Great! Thank you again very much! |
|
Flashed a RM XR1 RX with the latest Master/BAYCK C3 900/2400 Dualband 100mW 6PWM RX. Yes, it worked, and I got 4 PWM channels on TX,RX,TX2,RX2! However, as expected, the XR1 performs poorly with the "wrong" FW, very high RSS on both bands... There is a little difference in hardware between the XR1 and Bayck, but it is still interesting to be able to get 4 PWM channels with this type of Dualband RX with TX/RX2! So my question is whether ELRS would consider producing any working Dualband PWM FW for the RM XR series? |
No need to flash different firmware, just change the serial outputs to PWM in the webui. |
To be able to set PWM in the webui, RX needs to have PWM Fw, something that is not available for RM XR1 |
No, it does not. Modify the pin settings in hardware.html. Please come to the ELRS Discord if you need help setting it up. |
Thanks! Forgot/missed that option in "hardware", now I've fixed this, and everything works great! |
When implementing the secondary CRSF port is was a conscious decision to not send RC data to that port, as it was thought that it would really only be used for telemetry devices like GPS etc.
But, it's not that difficult to do and should be very little over head to achieve so, why not.
Fixes #3346