Reduce RAM usage #3238
Merged
Reduce RAM usage #3238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces RAM usage when not in MAVLink mode.
wvarty
approved these changes
Jun 2, 2025
CapnBry
approved these changes
Jun 3, 2025
Member
CapnBry
left a comment
There was a problem hiding this comment.
Just the fix I would have used for the mavlink buffer but goes above and beyond as usual. Thank you for moving the mavlink code into the mavlink class and out of the main loop too!
Tested with Betaflight and Rotorflight telemetry.
mha1
approved these changes
Jun 3, 2025
Contributor
mha1
left a comment
There was a problem hiding this comment.
tested ok in CRSF mode with heavy telemetry load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the giant MAVLink FIFO into the SerialMAVLink class and having a shared telemetry buffer allows us to reduce the RAM using in both CRSF mode and MAVLink mode.