Reduce lua bad/good queries around user pressing ENTER #3230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a changes the lua's internal behavior to skip doing any
crossfireTelemetryPush()when the user presses ENTER and delay the next bad/good fetch. This is to fix the issue of occasional (too frequent) times where changing a value doesn't work and the value goes back to its original value.Issue
Way too frequently, changing a value in the lua and pressing ENTER results in the value reverting to its original value when the automatic refresh takes place. To reproduce:
Eventually one of these changes will not take effect and revert to the previous value. The timing on this is the problem so it is highly variable. The frequency of failure can be increased by changing the lua to poll bad/good more frequently (change
linkstatTimeout = time + 10in refreshNext for 100ms).Problems
After much analysis, there's two reasons this happens:
Solutions