-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adhere to the CRSF spec for folders #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adhere to the CRSF spec for folders #3123
Conversation
52c6e7f to
20a12f3
Compare
|
I was aware of this but never bothered to fix it because we don't use it and I didn't want to send any extra data to parse in the Lua that we wouldn't use 😆. Can you combine it with the existing code that does the same thing in |
|
I moved the special |
What is the reason to send this strange folder name? Just send an empty string. |
Because when we had to reverse engineer this thing we thought it might be necessary to make it work with Agent Lite. |
|
Mmh, TBS works well with an empty string as root folder name.
Paul Kendall ***@***.***> schrieb am Fr., 31. Jan. 2025,
07:39:
… The 0'th item sent is always a folder as well with name "HooJ" which
contains all the root level items.
What is the reason to send this strange folder name? Just send an empty
string.
Because when we had to reverse engineer this thing we thought it might be
necessary to make it work with Agent Lite.
—
Reply to this email directly, view it on GitHub
<#3123 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCLD7ZJ2CMPKXFK2MHBNC32NMLCNAVCNFSM6AAAAABWDVFLZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRWGQYTSMBTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Actually you can send anything as root folder name because it is not displayed. Btw any fancy polish coder entered current root folder name? |
That's interesting because TBS used to be called HooJ, that's why ours says HooJ as well. Maybe they changed it because they wanted to not be like us being like them! |
MUSTARDTIGERFPV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HooJ indeed
deadbytefpv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HooJ it is!
As described in #3121, ELRS was not correctly forming the folder parameter response packets.
As a side benefit, this fix makes TBS Agent lite much more usable with ELRS!
AgentLite prior to this PR
AgentLite after this PR