Skip to content

Conversation

@pkendall64
Copy link
Collaborator

@pkendall64 pkendall64 commented Jan 29, 2025

As described in #3121, ELRS was not correctly forming the folder parameter response packets.
As a side benefit, this fix makes TBS Agent lite much more usable with ELRS!

AgentLite prior to this PR

screen-2025-03-28-102628

AgentLite after this PR

screen-2025-03-28-103025
screen-2025-03-28-103032
screen-2025-03-28-103042

@CapnBry
Copy link
Member

CapnBry commented Jan 30, 2025

I was aware of this but never bothered to fix it because we don't use it and I didn't want to send any extra data to parse in the Lua that we wouldn't use 😆.

Can you combine it with the existing code that does the same thing in registerLUAParameter() (nullptr case)? The 0'th item sent is always a folder as well with name "HooJ" which contains all the root level items.

@pkendall64
Copy link
Collaborator Author

I moved the special nullptr case to static initialisation and removed the redundant code. Makes it a bit simpler.

@wimalopaan
Copy link

The 0'th item sent is always a folder as well with name "HooJ" which contains all the root level items.

What is the reason to send this strange folder name? Just send an empty string.

@pkendall64
Copy link
Collaborator Author

The 0'th item sent is always a folder as well with name "HooJ" which contains all the root level items.

What is the reason to send this strange folder name? Just send an empty string.

Because when we had to reverse engineer this thing we thought it might be necessary to make it work with Agent Lite.

@wimalopaan
Copy link

wimalopaan commented Jan 31, 2025 via email

@JimB40
Copy link

JimB40 commented Jan 31, 2025

Actually you can send anything as root folder name because it is not displayed.
'root' as name should be default but if you code 'elrs_main_folder' it will work as long as name ends with 0x00

Btw any fancy polish coder entered current root folder name?
Phonetically sounds insulting :)

@CapnBry
Copy link
Member

CapnBry commented Jan 31, 2025

Mmh, TBS works well with an empty string as root folder name.

That's interesting because TBS used to be called HooJ, that's why ours says HooJ as well. Maybe they changed it because they wanted to not be like us being like them!

@CapnBry CapnBry self-requested a review January 31, 2025 22:12
Copy link
Member

@MUSTARDTIGERFPV MUSTARDTIGERFPV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HooJ indeed

Copy link
Contributor

@deadbytefpv deadbytefpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HooJ it is!

@pkendall64 pkendall64 merged commit 6a0e384 into ExpressLRS:3.x.x-maintenance Mar 31, 2025
48 checks passed
@pkendall64 pkendall64 deleted the crsf-folder-fixes branch March 31, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ELRS response to CRSF-request of folder-type parameters

6 participants