Skip to content

Conversation

@JyeSmith
Copy link
Member

@JyeSmith JyeSmith commented Jan 4, 2025

RF power for the SX12xx is currently done after txdone. This is a good time to do it for things like dyn power as time is available for the spi commands.

However the LR1121 also has a number of RF amps and they must be configured correctly for each frequency domain. Waiting until after the first packet has been sent and for the txdone isr isn't ideal, the wrong Dio pins can be used for txen on this first packet.

This PR also makes sure the correct amp is set for the first bind packet, and during CW.

SPI traffic is also reduced during dyn power changes as now only the power is set and not the RF amp configuration.

Copy link
Collaborator

@pkendall64 pkendall64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pkendall64 pkendall64 merged commit b6f1ebd into 3.x.x-maintenance Jan 11, 2025
96 checks passed
@pkendall64 pkendall64 deleted the LR1121_init_power_config branch January 11, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants