-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Device/event framework optimisation #3049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pkendall64
merged 5 commits into
ExpressLRS:master
from
pkendall64:next/event-subscription
Dec 18, 2024
Merged
Device/event framework optimisation #3049
pkendall64
merged 5 commits into
ExpressLRS:master
from
pkendall64:next/event-subscription
Dec 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s configuration If they return false then they are never called again
JyeSmith
reviewed
Nov 25, 2024
mha1
approved these changes
Dec 5, 2024
Contributor
mha1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works with no obvious errors on rx and module, e.g. both serials ok, pwm ok, module screen ok.
JyeSmith
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two parts to this PR.
falsefrom theirinitfunction and the device framework will not call theirstart,timeoutoreventfunctions during the main loop.eventfunction will only be called if that type of event is fired.