Communicate Rx available antenna mode to the Tx #3039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LR1121 working
…or-Gemini-mode-based-on-Tx-antenna-mode
…-MSP-(TLM-and-MAVLink)-througout-for-Gemini-hardware
…e-based-on-Tx-antenna-mode' into Double-MSP-(TLM-and-MAVLink)-througout-for-Gemini-hardware
…(TLM-and-MAVLink)-througout-for-Gemini-hardware
This reduces the number of partially filled pkts OTA via the SS. This need to be done correctly and in a generic way!!!
…nd-MAVLink)-througout-for-Gemini-hardware
wvarty
approved these changes
Dec 26, 2024
pkendall64
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of #3037 it is possible to break MSP comms when the Tx is in Gemini and the Rx only has a single radio. This PR forces the Tx into a single radio mode (SWITCH) when the Rx is not Gemini capable.
This mightnt be the best way to communicate the information if we decided the Tx should know a lot more about the Rx. Maybe a MSP Rx Info packet should be considered in the future?
Marking as a draft since this PR is built on #3037 which take advantage of this feature.