Skip to content

Phase 5: STM32 Obliteration: RX device cleanup #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pkendall64 merged 6 commits into from
Nov 12, 2024
Merged

Phase 5: STM32 Obliteration: RX device cleanup #3027

pkendall64 merged 6 commits into from
Nov 12, 2024

Conversation

@pkendall64
Copy link
Collaborator

@pkendall64 pkendall64 commented Nov 11, 2024

This one just cleans up a lot of the defines that were there to disable certain features that were not available to STM32 based receivers.

@pkendall64 pkendall64 added V4.0 🍔 house keeping 🧹 Cleanup of code and house keeping labels Nov 11, 2024
JyeSmith
JyeSmith approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@JyeSmith JyeSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with Nomad to BAYCK rx and mavlink... didnt break!

@Mkorho
Copy link

Mkorho commented Nov 11, 2024

Will external i2c baro still work with ESP8285 devices?
As there is lot of new defined(PLATFORM_ESP32) exclusions.
Or does ESP8285 belong to PLATFORM_ESP32?

I have many gliders that use ESP8285 based PWM receivers and i2c baro sensors.

@pkendall64
Copy link
Collaborator Author

pkendall64 commented Nov 12, 2024

Will external i2c baro still work with ESP8285 devices?

No, ESP8285 does not support the Baro sensors.

@Mkorho
Copy link

Mkorho commented Nov 12, 2024 •
edited
Loading

No, ESP8285 does not support the Baro sensors.

So you are going to remove support in 4.0?

Quote from #2480

ESP8266 unified targets also can use barometers now as well

@pkendall64
Copy link
Collaborator Author

pkendall64 commented Nov 12, 2024

No, ESP8285 does not support the Baro sensors.

So you are going to remove support in 4.0?

Quote from #2480

ESP8266 unified targets also can use barometers now as well

Well then it should still work. I'll have to check when I'm back with my gear.

@Mkorho
Copy link

Mkorho commented Nov 12, 2024

And will USE_MSP_WIFI change to PLATFORM_ESP32 break TCP Betaflight configurator from all ESP8285 receivers?
#1274

@pkendall64
Copy link
Collaborator Author

pkendall64 commented Nov 12, 2024

And will USE_MSP_WIFI change to PLATFORM_ESP32 break TCP Betaflight configurator from all ESP8285 receivers? #1274

No, because that will just change to TARGET_RX

@Mkorho
Copy link

Mkorho commented Nov 12, 2024

And will USE_MSP_WIFI change to PLATFORM_ESP32 break TCP Betaflight configurator from all ESP8285 receivers? #1274

No, because that will just change to TARGET_RX

image
I am talking about this change.
And it is not TARGET_RX.

@pkendall64
Copy link
Collaborator Author

pkendall64 commented Nov 12, 2024 •
edited
Loading

Oops, that is fixed in this PR now.

@pkendall64 pkendall64 force-pushed the phase-5-rx-device-cleanup branch from 118579d to e1a8c2d Compare November 12, 2024 03:55
@pkendall64 pkendall64 merged commit ef32864 into ExpressLRS:master Nov 12, 2024
@pkendall64 pkendall64 deleted the phase-5-rx-device-cleanup branch November 12, 2024 06:07
@mha1 mha1 mentioned this pull request Feb 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mha1 mha1 mha1 approved these changes

@JyeSmith JyeSmith JyeSmith approved these changes

@wvarty wvarty wvarty approved these changes

Assignees

No one assigned

Labels

house keeping 🧹 Cleanup of code and house keeping V4.0 🍔

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pkendall64 @Mkorho @mha1 @JyeSmith @wvarty