Maintain link connection on config.commit() for team900 #3014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvarty
approved these changes
Nov 2, 2024
pkendall64
approved these changes
Nov 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a Tx config.Commit() a call is made to SetRFLinkRate() to check if a new RF mode was set. When only something like the TLM ratio is changed SetRFLinkRate should bomb out and not set all of the OTA parameters again.
BUT! IQinverted is not used for Team900 and could return a different result to the inverted setting defined by the UID. It now appears as though the RF mode has changed and required reconfigurating. The link then get out of step with the rx and drops, or get stuck in a low LQ state.
This PR removed the IQinverted check as Modparams is more than enough for this check.
Fixes #2984