Fix Joystick mode to report as a "joystick" instead of a "gamepad" #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Im unable to test on Wine. But testing against Windows and the Game Controller setup, this doesnt appear to break anything. |
JyeSmith
approved these changes
Nov 2, 2024
mha1
approved these changes
Nov 3, 2024
Contributor
mha1
left a comment
There was a problem hiding this comment.
I can't test this PR using Wine. Working fine on Windows 11 Pro 23H2.
pkendall64
approved these changes
Nov 3, 2024
Collaborator
pkendall64
left a comment
There was a problem hiding this comment.
Tested on MacOS fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from doing some basic tests this doesnt affect windows at all since windows doesnt use Xinput for 99% of devices. but on linux running games under wine it does.
currently wine shows the controller as a Xinput device and Dinput device (in reality its feeding the Xinput to Dinput).
This causes only part of the buttons to work (anything that isnt a hat/Dpad), this also causes axis
Z&Rzto be merged as one.