Skip to content

Fix Airport communication #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JyeSmith merged 5 commits into from
Oct 19, 2024
Merged

Fix Airport communication #2988

JyeSmith merged 5 commits into from
Oct 19, 2024

Conversation

@JyeSmith
Copy link
Member

@JyeSmith JyeSmith commented Oct 17, 2024

3 fixes in this PR;

  • Add back the deleted OtaPackAirportData() to tx_main.
  • Correct the IF statement in rx_main by removing it and relocating OtaPackAirportData().
  • Fix the Airport baud if the rx has another protocol select besides CRSF.

@JyeSmith JyeSmith requested a review from wvarty October 17, 2024 06:45
@JyeSmith JyeSmith mentioned this pull request Oct 17, 2024
Closed
@JyeSmith JyeSmith changed the title Airport fix Fix Airport communication Oct 17, 2024
pkendall64
pkendall64 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@pkendall64 pkendall64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Ranger module and a BAYCKRC TD RX

@JyeSmith
Copy link
Member Author

JyeSmith commented Oct 18, 2024 •
edited
Loading

Argh, I think I broken linkstats which used to work for Airport.

Ill take another look...

Done

@JyeSmith JyeSmith mentioned this pull request Oct 18, 2024
Merged
wvarty
wvarty reviewed Oct 18, 2024
View reviewed changes
@JyeSmith JyeSmith mentioned this pull request Oct 19, 2024
Merged
@JyeSmith
Copy link
Member Author

JyeSmith commented Oct 19, 2024

Latest commit from Wez looks good.

@JyeSmith JyeSmith merged commit 08b37d3 into 3.x.x-maintenance Oct 19, 2024
@JyeSmith JyeSmith deleted the airport-fix branch October 19, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkendall64 pkendall64 pkendall64 approved these changes

@wvarty wvarty wvarty approved these changes

Assignees

No one assigned

Labels

bugfixes 🐞 V3.5 🍩

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JyeSmith @pkendall64 @wvarty