Remove Serial1 MAVLink check; MAVLink is supported on Serial0 only #2979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MUSTARDTIGERFPV
commented
Oct 11, 2024
mha1
previously requested changes
Oct 11, 2024
Contributor
mha1
left a comment
There was a problem hiding this comment.
You could further reduce this by deleting lines 536 and 537 and change the following if statement to be if (config.GetSerialProtocol() == PROTOCOL_MAVLINK)
JyeSmith
approved these changes
Oct 12, 2024
wvarty
approved these changes
Oct 20, 2024
pkendall64
requested changes
Oct 20, 2024
src/lib/LUA/rx_devLUA.cpp
Outdated
Comment on lines
537
to
539
| bool hasMavlink = prot0 == PROTOCOL_MAVLINK; | ||
| #if defined(PLATFORM_ESP32) | ||
| eSerial1Protocol prot1 = config.GetSerial1Protocol(); | ||
| hasMavlink = hasMavlink || (prot1 == PROTOCOL_MAVLINK); | ||
| #endif | ||
|
|
||
| if (hasMavlink) |
Collaborator
There was a problem hiding this comment.
Actually, these should always be registered i.e. no if block.
And at the end of event loop the fields should be shown/hidden depending on the protocol selected, similar to the backpack options on the TX side of things.
pkendall64
approved these changes
Oct 20, 2024
mha1
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.