-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Prevent vtx msp on tx boot #2965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Before reinstating the MSP sends on TLM connection, maybe review this: #1812 - I did not agree with how this was resolved at the time. It can fail the "principle of least astonishment" if the VTX is being configured via Betaflight, eg I use my 6-way switch to control the VTX tx power setting. Then suddenly in mid-flight, TLM disconnects and reconnects, and ELRS reconfigured the VTX in-flight which can have very bad consequences. I don't know if this is why it was taken out, but reconfiguring the VTX in-flight is, I think, almost always a bad idea. |
|
There was a resolution in #1812 that says if you are using any other method to set the VTX power level, then you should set the VTX admin power level to |
e9e0744 to
f7d2f27
Compare
|
I'm tagging myself onto this PR because the added VtxTriggerSend() breaks SPI RXs, which connect, then get a VTX update and forced save, which paused the FC/RX and drops the connection. It immediately reconnects (many times without even without there being any indication on the handset) which causes another VtxTriggerSend() and the cycle repeats indefinitely. This solution should be examined as it can also affect normal RX users I think if the timing works out just right, but I'll get back to it at a later time. |
This PR does 3 fixes;