Skip to content

Closes #873 Avoid double ASL4D registration #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jan-petr merged 1 commit into from
Dec 2, 2021
Merged

Closes #873 Avoid double ASL4D registration #966

jan-petr merged 1 commit into from
Dec 2, 2021

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Dec 2, 2021

Linked issue

Check out #873

How to test

Required: if not defined in the linked issue, add a simple test description here

Comments

Optional: add helpful comments for the reviewers here

@MichaelStritt MichaelStritt added the bug Something isn't working label Dec 2, 2021
@MichaelStritt MichaelStritt linked an issue Dec 2, 2021 that may be closed by this pull request
xASL_wrp_LinearReg_T1w2MNI detecting ASL4D twice #873
Closed
@HenkMutsaerts
Copy link
Member

HenkMutsaerts commented Dec 2, 2021

I think I wrote this, if Beatriz tested this, this should work. We should check carefully that it doesn't select ancillary files that shouldn't be coregistered.

Note that xASL_adm_GetFileList also checks for .nii.gz if .nii is requested, so that will work.

@jan-petr jan-petr requested review from HenkMutsaerts and removed request for HenkMutsaerts December 2, 2021 13:29
@jan-petr jan-petr force-pushed the bug-#873_LinearReg_T1w2MNI branch from a232d7c to e2a0815 Compare December 2, 2021 16:11
jan-petr
jan-petr approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jan-petr jan-petr force-pushed the bug-#873_LinearReg_T1w2MNI branch from e2a0815 to 1d5b521 Compare December 2, 2021 16:13
@jan-petr jan-petr merged commit 1d5b521 into develop Dec 2, 2021
@jan-petr jan-petr deleted the bug-#873_LinearReg_T1w2MNI branch December 2, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenkMutsaerts HenkMutsaerts HenkMutsaerts approved these changes

@jan-petr jan-petr jan-petr approved these changes

Assignees

@BeatrizPadrela BeatrizPadrela

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xASL_wrp_LinearReg_T1w2MNI detecting ASL4D twice

5 participants

@MichaelStritt @HenkMutsaerts @jan-petr @BeatrizPadrela