Skip to content

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Dec 2, 2021

Linked issue

#963

@jan-petr jan-petr self-assigned this Dec 2, 2021
@jan-petr jan-petr linked an issue Dec 2, 2021 that may be closed by this pull request
5 tasks
@MichaelStritt MichaelStritt added the feature New feature, enhancement or request label Dec 2, 2021
@MichaelStritt
Copy link
Contributor

For me personally dcm2niix still crashes (even though the up-to-date flavor library was used):

==============================================================================================
Importing subject = Sub1_1:   
Subject = Sub1, visit = 1, session = ASL_1, scan = ASL4D
executing: ["M:\SoftwareDevelopment\MATLAB\m.stritt\Server_xASL\ExploreASL\External\MRIcron\20190902\dcm2nii.exe" 
-f "%f_%p_%t_%s_%r" -o "M:\SoftwareDevelopment\MATLAB\m.stritt\Server_xASL\FlavorDatabase\Siemens_PCASL_3DGRASE_VD13A_Hadamard4FME_1\derivatives\ExploreASL\temp\Sub1\ASL_1\dcm2nii_temp_ASL4D"
"M:\SoftwareDevelopment\MATLAB\m.stritt\Server_xASL\FlavorDatabase\Siemens_PCASL_3DGRASE_VD13A_Hadamard4FME_1\sourcedata\Sub1\ASL\IM0007.0001.4914180.IMA"]
==============================================================================================

==============================================================================================
status: -1073740791
Warning: No NIfTIs found! Either illegal characters in filenames or other code defect... 
> In xASL_io_dcm2nii (line 251)

Copy link
Contributor

@MichaelStritt MichaelStritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so on Windows I still have my problems with the import. If @BeatrizPadrela can test and say if it works on Linux, I'm fine with it.

@BeatrizPadrela
Copy link
Contributor

Okay guys, I had to put an if loop here

image

because with Amnah's data (FME), we only have 2 repetitions, so this line makes sense and works for the next for loop of the averaging across repetitions.
However, with Philips data, since we have 12 repetitions, the size of ASL_im, divided by the 12 repetitions, gives the PLDs per repetition (7). If I used the same NumberofPLDs line that I used for FME data, in the foor loop, in line 251, in the last iteration, we would have 12 (number of rep) * 12 (84 / Had8-1 = 84/7 = 12), which would overfit the matrix size

Tell me what you think @MichaelStritt @jan-petr

@MichaelStritt
Copy link
Contributor

@jan-petr & @BeatrizPadrela: Possibly a stupid question from my side, but wouldn't it be easier to determine that based on the matrix size? Then your for loop can't crash.

By the way, there are no if loops, we call them if statements.

@BeatrizPadrela
Copy link
Contributor

@MichaelStritt that's a good idea!
And yes indeed, if statements and for loops, yesterday was already late :)

@jan-petr jan-petr force-pushed the feature-#963_HadamardDecodingPhilips branch from fccf7ee to 885b75f Compare December 8, 2021 11:25
@BeatrizPadrela BeatrizPadrela force-pushed the feature-#963_HadamardDecodingPhilips branch from 40f9a6f to afef36b Compare December 8, 2021 15:43
@BeatrizPadrela BeatrizPadrela merged commit afef36b into develop Dec 8, 2021
@BeatrizPadrela BeatrizPadrela deleted the feature-#963_HadamardDecodingPhilips branch December 8, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature, enhancement or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Philips Hadamard decoding

4 participants