Skip to content

Closes #948 Update x.SUBJECT/S and x.overview #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelStritt merged 2 commits into from
Nov 29, 2021
Merged

Closes #948 Update x.SUBJECT/S and x.overview #949

MichaelStritt merged 2 commits into from
Nov 29, 2021

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Nov 26, 2021

Linked issue

Check out the description in #948

Comments

Seems like we overlooked this minor bug in the previous merge.

@MichaelStritt MichaelStritt added the bug Something isn't working label Nov 26, 2021
@MichaelStritt MichaelStritt self-assigned this Nov 26, 2021
@MichaelStritt MichaelStritt linked an issue Nov 26, 2021 that may be closed by this pull request
Update x.SUBJECT/S and x.overview for subjects with illegal characters #948
Closed
@MichaelStritt MichaelStritt changed the title #948 Update x.SUBJECT/S and x.overview Closes #948 Update x.SUBJECT/S and x.overview Nov 26, 2021
jan-petr
jan-petr approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Modules/SubModule_Import/xASL_imp_DCM2NII.m Outdated
function x = xASL_imp_DCM2NII(x, imPar)
%xASL_imp_DCM2NII Run the dcm2nii part of the import.
%
% FORMAT: xASL_imp_DCM2NII(x, imPar)
Copy link
Contributor

@jan-petr jan-petr Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"x = " missing

Copy link
Contributor Author

@MichaelStritt MichaelStritt Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

jan-petr
jan-petr requested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor header thing

jan-petr
jan-petr approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@MichaelStritt MichaelStritt merged commit 0f7abf9 into develop Nov 29, 2021
@MichaelStritt MichaelStritt deleted the bug-#948_Import branch November 29, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

Assignees

@MichaelStritt MichaelStritt

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update x.SUBJECT/S and x.overview for subjects with illegal characters

3 participants

@MichaelStritt @jan-petr