Skip to content

Closes #942 Update ASLDRO #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelStritt merged 5 commits into from
Nov 26, 2021
Merged

Closes #942 Update ASLDRO #943

MichaelStritt merged 5 commits into from
Nov 26, 2021

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Nov 24, 2021 •
edited
Loading

Linked issue

Check out #942

How to test

[UnitTests,UnitTestsTable] = xASL_test_UnitTesting;

@MichaelStritt MichaelStritt added the testing Either unit testing or full pipeline testing for bugs label Nov 24, 2021
@MichaelStritt MichaelStritt linked an issue Nov 24, 2021 that may be closed by this pull request
Update all DRO unit tests (new v2.3.0 structure) #942
Closed
@MichaelStritt MichaelStritt self-assigned this Nov 25, 2021
@MichaelStritt
Copy link
Contributor Author

MichaelStritt commented Nov 25, 2021 •
edited
Loading

@jan-petr: xASL_ut_master_xASL_ExploreASL_Master.m still needs some work and I stumbled upon the bug that Henk mentioned a while ago. Determining the subject/session/run structure without a sourceStructure.json does not seem to work right now, which is why the sub-test 5 of xASL_ut_master_xASL_ExploreASL_Master.m fails. DCM2NII & BIDS2LEGACY works perfectly, but in NII2BIDS we need to determine subjects/sessions/runs as well for xASL_Iteration. Does this need to be fixed or are we going to make everything purely DCM->BIDS in the future?

jan-petr
jan-petr requested changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two minor things:

  • Please update the str to string at line Functions/xASL_bids_Config.m:15:%
    (my fault for not fixing it previously)
  • one comment in the code

@MichaelStritt MichaelStritt mentioned this pull request Nov 26, 2021
Merged
jan-petr
jan-petr approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@MichaelStritt MichaelStritt merged commit b1fc9c8 into develop Nov 26, 2021
@MichaelStritt MichaelStritt deleted the test-#942_DRO branch November 26, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

Assignees

@MichaelStritt MichaelStritt

Labels

testing Either unit testing or full pipeline testing for bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update all DRO unit tests (new v2.3.0 structure)

3 participants

@MichaelStritt @jan-petr