Skip to content

#930 xASL_Iteration: move logs #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelStritt merged 7 commits into from
Nov 25, 2021
Merged

#930 xASL_Iteration: move logs #935

MichaelStritt merged 7 commits into from
Nov 25, 2021

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Nov 20, 2021

Linked issue

#930

@MichaelStritt MichaelStritt added the revamp Restructuring of ExploreASL label Nov 20, 2021
@MichaelStritt MichaelStritt linked an issue Nov 20, 2021 that may be closed by this pull request
Move log files to log directory #930
Closed
@MichaelStritt

This comment has been minimized.

Sign in to view
@MichaelStritt
Copy link
Contributor Author

MichaelStritt commented Nov 20, 2021

derivatives

image

lock

image

log

image

@MichaelStritt MichaelStritt self-assigned this Nov 20, 2021
HenkMutsaerts
HenkMutsaerts requested changes Nov 21, 2021
View reviewed changes
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only now I see the figure, very nice!

Can we at the same time make sure that the naming is the same throughout. I wouldn't add the 'sub-' as this should have been done in the conversion. I would just use , without changing them or interpreting them.

Note that xASL_module_ASL_012S4093_2 should be xASL_module_ASL_012S4093_2_ASL_1 or xASL_module_ASL_012S4093_2_ASL_2. So for session modules it should be _.

In the future, we could move the file reports (Missing*.csv etc) there as well, but this will confuse the users. We shouldn't have too many small changes from version to version, or the users will get crazy. Let's add this to our wishlist for version 2.0 :)

@MichaelStritt
Copy link
Contributor Author

MichaelStritt commented Nov 22, 2021

@HenkMutsaerts: Should work with c7051c9. If a user defines sub-[...] as the subject id instead of [...] we would have sub-sub-[...] though. There's no way around it though, since you can't use regular expressions for the symbolic fields within xASL_Iteration. You could implement that later on, but that wouldn't be too clean either. I'd leave it as it is right now.

jan-petr
jan-petr approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@MichaelStritt MichaelStritt merged commit e3097d9 into develop Nov 25, 2021
@MichaelStritt MichaelStritt deleted the log-#930_Revamp branch November 25, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

@HenkMutsaerts HenkMutsaerts Awaiting requested review from HenkMutsaerts

Assignees

@MichaelStritt MichaelStritt

Labels

revamp Restructuring of ExploreASL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move log files to log directory

4 participants

@MichaelStritt @HenkMutsaerts @jan-petr