Skip to content

Fixes #855 SPM unit tests #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelStritt merged 4 commits into from
Sep 30, 2021
Merged

Fixes #855 SPM unit tests #856

MichaelStritt merged 4 commits into from
Sep 30, 2021

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Sep 27, 2021 •
edited
Loading

Linked issue

Check out #855

How to test

Run these tests:

TestRepository = '...';
UnitTest1 = xASL_ut_function_xASL_spm_reslice(TestRepository);
UnitTest2 = xASL_ut_function_xASL_spm_smooth(TestRepository);
UnitTest3 = xASL_ut_function_xASL_spm_admin(TestRepository);

Comments

@jan-petr: This is just a starting point for us to get some unit tests for the actual image processing. No over-engineering here. Let's start simple. No special requests, please.

@MichaelStritt MichaelStritt added testing Either unit testing or full pipeline testing for bugs aspire ASPIRE project related issues labels Sep 27, 2021
@MichaelStritt MichaelStritt linked an issue Sep 27, 2021 that may be closed by this pull request
Add initial spm tests #855
Closed
@MichaelStritt MichaelStritt self-assigned this Sep 27, 2021
jan-petr
jan-petr approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good - hopefully, there won't be any issues with the smoothing - we've seen some between OS differences and between Matlab version difference in Matlab convolution (the smoothing).

@MichaelStritt
Copy link
Contributor Author

MichaelStritt commented Sep 30, 2021

Looks all good - hopefully, there won't be any issues with the smoothing - we've seen some between OS differences and between Matlab version difference in Matlab convolution (the smoothing).

Ah, don't worry. It's just a basic example for a unit test, so it doesn't affect the pipeline. We'll see if it makes huge differences during the next release 😉

@MichaelStritt MichaelStritt merged commit 0d7e133 into develop Sep 30, 2021
@MichaelStritt MichaelStritt deleted the spm-#855_Testing branch September 30, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

Assignees

@MichaelStritt MichaelStritt

Labels

aspire ASPIRE project related issues testing Either unit testing or full pipeline testing for bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add initial spm tests

3 participants

@MichaelStritt @jan-petr