Skip to content

Bug #784 m0 type bid simport #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelStritt merged 2 commits into from
Aug 17, 2021
Merged

Bug #784 m0 type bid simport #785

MichaelStritt merged 2 commits into from
Aug 17, 2021

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Aug 17, 2021

Linked issue

#784

Comments

To make the import of ADNI Philips work

@jan-petr jan-petr requested a review from MichaelStritt August 17, 2021 19:54
@jan-petr jan-petr self-assigned this Aug 17, 2021
@jan-petr jan-petr linked an issue Aug 17, 2021 that may be closed by this pull request
BIDS import accepts only legacy M0 #784
Closed
@MichaelStritt MichaelStritt added the bug Something isn't working label Aug 17, 2021
@MichaelStritt
Copy link
Contributor

MichaelStritt commented Aug 17, 2021

Philips_PASL_2DEPI_5.4.1.0_ADNI3_006_S_6681_1

Converted the dataset as a test and loaded it afterwards. Everything worked fine 👍

>> x = ExploreASL(pathTest,0,0);
ExploreASL will load the dataset...
==============================================================================================
 ________                      __                                 ______    ______   __        
/        |                    /  |                               /      \  /      \ /  |      
########/  __    __   ______  ## |  ______    ______    ______  /######  |/######  |## |      
## |__    /  \  /  | /      \ ## | /      \  /      \  /      \ ## |__## |## \__##/ ## |      
##    |   ##  \/##/ /######  |## |/######  |/######  |/######  |##    ## |##      \ ## |      
#####/     ##  ##<  ## |  ## |## |## |  ## |## |  ##/ ##    ## |######## | ######  |## |      
## |_____  /####  \ ## |__## |## |## \__## |## |      ########/ ## |  ## |/  \__## |## |_____ 
##       |/##/ ##  |##    ##/ ## |##    ##/ ## |      ##       |## |  ## |##    ##/ ##       |
########/ ##/   ##/ #######/  ##/  ######/  ##/        #######/ ##/   ##/  ######/  ########/ 
                    ## |                                                                      
                    ## |                                                                      
                    ##/  

==================================== ExploreASL Settings =====================================
Dataset Root        ...\Server_xASL\Old_TestData\Philips_PASL_2DEPI_5.4.1.0_ADNI3_006_S_6681_1
Import Modules      
Process Modules     
bPause              False
iWorker             1
nWorkers            1
==============================================================================================
ExploreASL v1.8.0_BETA initialized ... 


Automatically defining sessions...
==================================== Additional Settings =====================================
1 scans - 0 exclusions, resulting in 1 scans of: 
Longitudinal timePoint 1 = 1 scans - 0 exclusions = 1 scans
ASL sessions: 1

Ancillary data, sets: 4 sets are defined for 1 "SubjectsSessions"
Set 1 = "session" options "ASL_1", codes for paired data
Set 2 = "LongitudinalTimePoint" options "TimePoint_1", codes for paired data
Set 3 = "SubjectNList" options "SubjectNList", codes for paired data
Set 4 = "Site" options "SingleSite", codes for two-sample data
x.D.ROOT            ...\Philips_PASL_2DEPI_5.4.1.0_ADNI3_006_S_6681_1\derivatives\ExploreASL
x.settings.DELETETEMP 1 (delete temporary files)
x.settings.Quality    1 (0 = fast try-out; 1 = normal high quality)

==============================================================================================

MichaelStritt
MichaelStritt approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@MichaelStritt MichaelStritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks really nice with the switch statement. I only did minor testing, but I guess we have to do real thorough testing of all datasets soon anyway 👍

@MichaelStritt MichaelStritt merged commit a8ad7cd into develop Aug 17, 2021
@MichaelStritt MichaelStritt deleted the bug_#784-M0TypeBIDSimport branch August 17, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MichaelStritt MichaelStritt MichaelStritt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MichaelStritt MichaelStritt

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BIDS import accepts only legacy M0

3 participants

@jan-petr @MichaelStritt