Skip to content

#187 xASL_io_Nifti2Im: Load as uint8 int16 or single #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jan-petr merged 1 commit into from
Jul 2, 2021
Merged

#187 xASL_io_Nifti2Im: Load as uint8 int16 or single #671

jan-petr merged 1 commit into from
Jul 2, 2021

Conversation

@HenkMutsaerts
Copy link
Member

@HenkMutsaerts HenkMutsaerts commented Jun 19, 2021

Linked issue

Closes #187

@HenkMutsaerts HenkMutsaerts linked an issue Jun 19, 2021 that may be closed by this pull request
If xASL_io_Nifti2Im loads a mask, don’t use single() but logical() #187
Closed
@MichaelStritt MichaelStritt added the optimization Ensure that code runs faster with unchanged functionality label Jun 21, 2021
jan-petr
jan-petr approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jan-petr jan-petr requested review from jan-petr and removed request for BeatrizPadrela July 2, 2021 10:00
@jan-petr jan-petr assigned jan-petr and unassigned BeatrizPadrela Jul 2, 2021
jan-petr
jan-petr approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@jan-petr jan-petr force-pushed the opt-#187_xASL_io_Nifti2Im_UINT8_INT16 branch from e108a88 to 51dfbf9 Compare July 2, 2021 10:02
@jan-petr jan-petr merged commit 51dfbf9 into develop Jul 2, 2021
@jan-petr jan-petr deleted the opt-#187_xASL_io_Nifti2Im_UINT8_INT16 branch July 2, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

Assignees

@jan-petr jan-petr

Labels

optimization Ensure that code runs faster with unchanged functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If xASL_io_Nifti2Im loads a mask, don’t use single() but logical()

5 participants

@HenkMutsaerts @jan-petr @MichaelStritt @BeatrizPadrela