Skip to content

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Jun 9, 2021

Linked issue

#631

How to test

Run Flavors to see if this doesn't appear twice anymore - tested by Jan.

@jan-petr jan-petr requested a review from HenkMutsaerts June 9, 2021 14:52
@jan-petr jan-petr self-assigned this Jun 9, 2021
@jan-petr jan-petr linked an issue Jun 9, 2021 that may be closed by this pull request
@HenkMutsaerts
Copy link
Member

This looks good, I asked @BeatrizPadrela to check if this warning is not repeated anymore. In fact, this may be a general problem, what to do if the same warning is mentioned 100 times when you have 100 subjects. Perhaps we could think of a general transparent solution for this?

@HenkMutsaerts
Copy link
Member

I see now that I'm confusing this issue with the other... So this comment should be moved then (typing this in my bed from my phone... Tried the laptop in bed but Kyra gets mad (that rhymes)

@BeatrizPadrela
Copy link
Contributor

I see now that I'm confusing this issue with the other... So this comment should be moved then (typing this in my bed from my phone... Tried the laptop in bed but Kyra gets mad (that rhymes)

No this is the right issue, but Jan rmeoved the wrong warning

@jan-petr jan-petr force-pushed the optimize_#631-MultipleM0warning branch from e6f3369 to fb4a618 Compare June 13, 2021 21:30
@jan-petr jan-petr merged commit fb4a618 into develop Jun 13, 2021
@jan-petr jan-petr deleted the optimize_#631-MultipleM0warning branch June 13, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning for M0 repeated multiple times for multiple runs

4 participants