Skip to content

Closes #439 Rename MNI_structural to MNI_Structural #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelStritt merged 2 commits into from
Mar 23, 2021
Merged

Closes #439 Rename MNI_structural to MNI_Structural #440

MichaelStritt merged 2 commits into from
Mar 23, 2021

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Mar 23, 2021

No description provided.

@MichaelStritt MichaelStritt added the bug Something isn't working label Mar 23, 2021
@MichaelStritt MichaelStritt self-assigned this Mar 23, 2021
@MichaelStritt MichaelStritt linked an issue Mar 23, 2021 that may be closed by this pull request
HotFix request - Consistent naming for MNI Structural atlas #439
Closed
jan-petr
jan-petr approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@MichaelStritt
Copy link
Contributor Author

MichaelStritt commented Mar 23, 2021

Minor test

>> DataParPath = '.\Test_Runs\TestDataSet\analysis\DataParameters_LowQ.json';
>> [x] = ExploreASL_Master(DataParPath, 1, 1);
--> Initializing ExploreASL v1.5.0...


==============================================================================================
 ________                      __                                 ______    ______   __        
/        |                    /  |                               /      \  /      \ /  |      
########/  __    __   ______  ## |  ______    ______    ______  /######  |/######  |## |      
## |__    /  \  /  | /      \ ## | /      \  /      \  /      \ ## |__## |## \__##/ ## |      
##    |   ##  \/##/ /######  |## |/######  |/######  |/######  |##    ## |##      \ ## |      
#####/     ##  ##<  ## |  ## |## |## |  ## |## |  ##/ ##    ## |######## | ######  |## |      
## |_____  /####  \ ## |__## |## |## \__## |## |      ########/ ## |  ## |/  \__## |## |_____ 
##       |/##/ ##  |##    ##/ ## |##    ##/ ## |      ##       |## |  ## |##    ##/ ##       |
########/ ##/   ##/ #######/  ##/  ######/  ##/        #######/ ##/   ##/  ######/  ########/ 
                    ## |                                                                      
                    ## |                                                                      
                    ##/  
==============================================================================================
...

image

I only had some change notification handle warnings, other than that, everything should be fine.

@MichaelStritt MichaelStritt merged commit ff38748 into main Mar 23, 2021
@MichaelStritt MichaelStritt deleted the hotfix-#439_v1.5.1 branch March 23, 2021 10:51
@jan-petr jan-petr removed the request for review from HenkMutsaerts March 23, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-petr jan-petr jan-petr approved these changes

@BeatrizPadrela BeatrizPadrela BeatrizPadrela approved these changes

@MDijsselhof MDijsselhof MDijsselhof approved these changes

Assignees

@MichaelStritt MichaelStritt

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HotFix request - Consistent naming for MNI Structural atlas

5 participants

@MichaelStritt @jan-petr @BeatrizPadrela @MDijsselhof