Skip to content

#182 WM overlay for QC with contours and template WM. #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HenkMutsaerts merged 6 commits into from
Jul 11, 2021
Merged

#182 WM overlay for QC with contours and template WM. #183

HenkMutsaerts merged 6 commits into from
Jul 11, 2021

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Oct 14, 2020

Closes #182

  • Overlays in ASLCheck can now use also the template version of GM and WM and not only individual segmentations.
  • Overlays in ASLCheck can now be also contours and not full ROIs.

@jan-petr jan-petr added this to the Release 1.4.0 milestone Oct 14, 2020
@jan-petr jan-petr self-assigned this Oct 14, 2020
@jan-petr jan-petr linked an issue Oct 14, 2020 that may be closed by this pull request
Visualization of CBF+WM - contour and template WM #182
Closed
HenkMutsaerts
HenkMutsaerts requested changes Nov 21, 2020
View reviewed changes
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment •
edited by jan-petr
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDITED by Jan - included also the requested changes from PR.

  • The DataParTemplate.m needs to have a clearer description
  • The contour visualization function should not be inside the wrapper but in a function. Adding it as option to xASL_vis_CreateVisualFig would be best (So the most transparent way is to add the contour option to the function, and in the wrapper state in which cases we want this option (i.e. the booleans you created). Instead, you added all functionality to the wrapper ;) So the solution is to move the contour creation etc to the function, and keep the booleans (i.e. the ExploreASL wrapping part) in the wrapper, don't you agree?)
  • xASL_delete already checks for if exist, including gz support, so this can be shortened (by removing the if exist() part
  • pGMC is a bit unclear, would replace by pGM_contour

@HenkMutsaerts HenkMutsaerts removed this from the Release 1.4.0 milestone Jan 13, 2021
Base automatically changed from develop to developBackup January 18, 2021 18:31
Base automatically changed from developBackup to developOld January 18, 2021 18:41
Base automatically changed from developOld to develop January 18, 2021 20:30
@MichaelStritt MichaelStritt added the feature New feature, enhancement or request label Feb 12, 2021
HenkMutsaerts
HenkMutsaerts requested changes Jun 1, 2021
View reviewed changes
@HenkMutsaerts
Copy link
Member

HenkMutsaerts commented Jun 12, 2021

@jan-petr I fixed my last requests, so you're good to go

@HenkMutsaerts HenkMutsaerts force-pushed the feature-#182_CBFWMoverlayNewFeatures branch from ba91e88 to 9b22b78 Compare July 11, 2021 15:33
@HenkMutsaerts HenkMutsaerts merged commit 9b22b78 into develop Jul 11, 2021
@HenkMutsaerts HenkMutsaerts deleted the feature-#182_CBFWMoverlayNewFeatures branch July 11, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenkMutsaerts HenkMutsaerts HenkMutsaerts approved these changes

Assignees

@jan-petr jan-petr

Labels

feature New feature, enhancement or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Visualization of CBF+WM - contour and template WM

4 participants

@jan-petr @HenkMutsaerts @MichaelStritt