Skip to content

#1290 Fix progress formatting in xASL_module_BIDS2Legacy #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jan-petr merged 1 commit into from
Jan 31, 2023
Merged

#1290 Fix progress formatting in xASL_module_BIDS2Legacy #1297

jan-petr merged 1 commit into from
Jan 31, 2023

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Jan 20, 2023 •
edited
Loading

Linked issue

Closes #1290

@jan-petr jan-petr requested a review from MDijsselhof January 20, 2023 14:44
@jan-petr jan-petr self-assigned this Jan 20, 2023
@jan-petr jan-petr linked an issue Jan 20, 2023 that may be closed by this pull request
BIDS2legacy counter goes above 100% #1290
Closed
@HenkMutsaerts HenkMutsaerts requested review from HenkMutsaerts and removed request for MDijsselhof January 31, 2023 19:12
HenkMutsaerts
HenkMutsaerts approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this solves the issue of going beyond 100%...

@jan-petr jan-petr force-pushed the bug-#1290_BIDS2LegacyCounter branch from 643f2cc to 7ac7e56 Compare January 31, 2023 19:51
@jan-petr jan-petr merged commit 7ac7e56 into develop Jan 31, 2023
@jan-petr jan-petr deleted the bug-#1290_BIDS2LegacyCounter branch January 31, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenkMutsaerts HenkMutsaerts HenkMutsaerts approved these changes

Assignees

@jan-petr jan-petr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BIDS2legacy counter goes above 100%

3 participants

@jan-petr @HenkMutsaerts