Skip to content

Feature #1079 miscellaneous #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jan-petr merged 9 commits into from
Nov 14, 2022
Merged

Feature #1079 miscellaneous #1234

jan-petr merged 9 commits into from
Nov 14, 2022

Conversation

@jan-petr
Copy link
Contributor

@jan-petr jan-petr commented Nov 7, 2022

Linked issue

Closes #1079

jan-petr
jan-petr commented Nov 7, 2022
View reviewed changes
Copy link
Contributor Author

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment.

@jan-petr jan-petr self-assigned this Nov 8, 2022
@HenkMutsaerts HenkMutsaerts linked an issue Nov 10, 2022 that may be closed by this pull request
Miscellaneous improvements #1079
Closed
7 tasks
HenkMutsaerts
HenkMutsaerts requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny to notice after the fact that I'm reviewing my own work ;)

@jan-petr
Copy link
Contributor Author

jan-petr commented Nov 10, 2022

Funny to notice after the fact that I'm reviewing my own work ;)

I know. That's the drawback when somebody else creates an issue :D

HenkMutsaerts
HenkMutsaerts requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check my last few additions? I just added it here, I know I was the one wanting to keep issues separate in the past, so sorry about my inconsistency ;) This was a small change, should work fine.

@jan-petr
Copy link
Contributor Author

jan-petr commented Nov 10, 2022

Can you check my last few additions? I just added it here, I know I was the one wanting to keep issues separate in the past, so sorry about my inconsistency ;) This was a small change, should work fine.

I have no issue with that. So if you don't complain about it yourself, I'm fine :D

@jan-petr jan-petr force-pushed the feature-#1079_Miscellaneous branch from 12803cb to c2693a9 Compare November 14, 2022 16:43
@jan-petr jan-petr merged commit c2693a9 into develop Nov 14, 2022
@jan-petr jan-petr deleted the feature-#1079_Miscellaneous branch November 14, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenkMutsaerts HenkMutsaerts HenkMutsaerts approved these changes

Assignees

@jan-petr jan-petr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Miscellaneous improvements

3 participants

@jan-petr @HenkMutsaerts