Skip to content

Conversation

@HenkMutsaerts
Copy link
Member

@HenkMutsaerts HenkMutsaerts commented Oct 13, 2022

Linked issue

Closes #1197

How to test

  • Add "x.S.DataTypes": ["qCBF", "Texch"] to dataPar.json and run the population module @BeatrizPadrela to test if this new feature works
  • Run the population module without this new setting to see if the default still works (it should default to qCBFas it originally did)

Comments

@jan-petr Should we add this new parameter to the dataParTemplate.md (this is now removed and only online right?)

Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things.
Also, we should add this new dataPar parameter to the Documentation.
Can you please draft something and I'll put it here?
https://exploreasl.github.io/Documentation/1.10.0beta/ProcessingParameters/

@jan-petr jan-petr linked an issue Oct 14, 2022 that may be closed by this pull request
2 tasks
@jan-petr jan-petr self-assigned this Oct 14, 2022
@HenkMutsaerts
Copy link
Member Author

Can you re-review?

For the dataPar template online:

x.S.[...]

DataTypes = Vector of cells specifying which images to take data from, in the ROI analysis. E.g., {'Tex’, 'ATT' 'SD' 'M0' ‘rc1T1’}

OPTIONAL, DEFAULT = {‘qCBF’}

@jan-petr jan-petr requested review from jan-petr and removed request for BeatrizPadrela October 14, 2022 19:07
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jan-petr jan-petr force-pushed the feature-#1197_DataTypes branch from f247114 to 824fc2c Compare October 14, 2022 19:11
@jan-petr jan-petr merged commit 824fc2c into develop Oct 14, 2022
@jan-petr jan-petr deleted the feature-#1197_DataTypes branch October 14, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iterate Statistics over multiple DataTypes (E.g., TExch, SD, etc)

3 participants