-
Notifications
You must be signed in to change notification settings - Fork 13
Feature #1129 multi study context #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Few points
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a warning for each inheritance case, and see my comment for studyParClean, otherwise I'm fine.
OK. I fixed the studyParClean. In a bit different way - I keep studyPar as it was without changing it. And I only clean the fields from the result. This is even more clean solution. I made a few more edits addressing a few more comments. Can I resolve the rest? Regarding the warnings - we have to keep it relatively simple. And we can't report on general basis. As we want to keep things modular and this report will change based on what subjects are included and can therefore differ on a re-run with a more complete dataset. So I propose to report something like this:
Any preference? |
|
HENK: When it reads the non-first study par, it warns "Note that for subjects XX sessions YY we're using parameter XX instead of YY" And check the main issue comment. |
|
I have copied the same answer to PR as well:
This doesn't make sense IMHO. Because this only states the basic functionality of the multi-parameter studyPar :) It doesn't make to report general warning, it makes sense to only report specific warnings to cases that are actually happening. An example of a current warning is:
I agree in general with #1193, but note that we will anyway revamp the legacy structure of parameters that dataPar uses - so things might still change a bit. Anyway - I agree that we have to clean that. These things happen step-by-step - don't criticize when things are a mess, because they were a super-mess before :D |
BeatrizPadrela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!!
|
No I wouldn't provide this information on a subject-by-subject basis, because that will be lost in the long log-list. Instead, at the beginning of the whole conversion: you give a single big warning:
JAN: But this is verbatim what is written in the Main reason is that your warnings are lost in the gigantic list of import text. If you concentrate all We can also have both. JAN: OK. We keep the current small warning per subject. And we will try to make an overview reminder for all in a new issue. |
0098f23 to
76f32a1
Compare
Linked issue
Closes #1129
How to test
Check flavor /Siemens_PCASL_3DGRASE_VD13A_DEBBIE_1 and Siemens_PCASL_multi_VE11C_1