Skip to content

Conversation

@MDijsselhof
Copy link
Contributor

Linked issue

Closes #685

How to test

Required: if not defined in the linked issue, add a simple test description here

Comments

Optional: add helpful comments for the reviewers here

@MDijsselhof MDijsselhof requested a review from jan-petr January 24, 2022 10:19
@MichaelStritt MichaelStritt changed the title #685 changed template names Closes #685 changed template names Jan 24, 2022
@MichaelStritt MichaelStritt added the minor improvements Fixes that don't change main pipeline functionality label Jan 24, 2022
@MichaelStritt MichaelStritt linked an issue Jan 24, 2022 that may be closed by this pull request
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change .mat back to .nii.mat - see Whatsapp.

Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .nii.mat -> .mat etension renaming is wrong, the filename renaming is nice

Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the extensions. So all should be good now.

Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that we tested the new atlases/names in the population module

@jan-petr jan-petr force-pushed the minor_improvement-#685_TemplateAbbreviationMismatch branch from 1ee79c3 to d656d3b Compare March 22, 2022 07:50
@jan-petr jan-petr merged commit d656d3b into develop Mar 22, 2022
@jan-petr jan-petr deleted the minor_improvement-#685_TemplateAbbreviationMismatch branch March 22, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor improvements Fixes that don't change main pipeline functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template abbreviation dataPar.json mismatch

5 participants