-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
Labels
bidsMoving ExploreASL to BIDS compatibilityMoving ExploreASL to BIDS compatibilitybugSomething isn't workingSomething isn't working
Milestone
Description
Description
Several issues to be fixed:
EchoNumberDICOM tag should not go to BIDS. c3c2631 👍TimeEncodedEchoTimesis correctly calculated and needed for processing and QA, but should not be saved to BIDS. I thus propose to make a new function to calculate it centrally and move the code fromxASL_bids_BIDSifyCheckTimeEncoded.mto it. Then still call this new function from there as we need it to calculate the number of repetitions. But then not save it to BIDS or Legacy, but recalculate again in xASL_module. The only reason being that this variable can easily be obtained from the TE vector and will thus probably not make it into the BIDS definition once Hadamard is included. Also, this should be renamed toNumberEchoTimesas it is a general parameter. 2db00c4 👍- TotalAcquired pairs should refer to number of repetitions = full pairs C/L or full set of Hadamard matrix. 604b0af 👍
- Lastly,
TimeEncodedMatrixType,TimeEncodedMatrixSize,NumberEchoTimesshould go to x.Q. And only bMultiTE etc should stay in x.modules.asl. 0662f7b 👍 - Rename DecodingMatrix to TimeEncodedMatrix and fix the call of
xASL_quant_HadamardDecodingso that we pass x.Q field and not some xDecoding field that might sound unclear. a45bf7a 👍
Release notes
Removed EchoNumber and TimeEncodedEchoTimes fields from BIDS and optimized Hadamard import and initialization.
Metadata
Metadata
Assignees
Labels
bidsMoving ExploreASL to BIDS compatibilityMoving ExploreASL to BIDS compatibilitybugSomething isn't workingSomething isn't working