Skip to content

Bremen Hadamard import and initialization #959

@jan-petr

Description

@jan-petr

Description

Several issues to be fixed:

  • EchoNumber DICOM tag should not go to BIDS. c3c2631 👍
  • TimeEncodedEchoTimes is correctly calculated and needed for processing and QA, but should not be saved to BIDS. I thus propose to make a new function to calculate it centrally and move the code from xASL_bids_BIDSifyCheckTimeEncoded.m to it. Then still call this new function from there as we need it to calculate the number of repetitions. But then not save it to BIDS or Legacy, but recalculate again in xASL_module. The only reason being that this variable can easily be obtained from the TE vector and will thus probably not make it into the BIDS definition once Hadamard is included. Also, this should be renamed to NumberEchoTimes as it is a general parameter. 2db00c4 👍
  • TotalAcquired pairs should refer to number of repetitions = full pairs C/L or full set of Hadamard matrix. 604b0af 👍
  • Lastly, TimeEncodedMatrixType, TimeEncodedMatrixSize, NumberEchoTimes should go to x.Q. And only bMultiTE etc should stay in x.modules.asl. 0662f7b 👍
  • Rename DecodingMatrix to TimeEncodedMatrix and fix the call of xASL_quant_HadamardDecoding so that we pass x.Q field and not some xDecoding field that might sound unclear. a45bf7a 👍

Release notes

Removed EchoNumber and TimeEncodedEchoTimes fields from BIDS and optimized Hadamard import and initialization.

Metadata

Metadata

Assignees

Labels

bidsMoving ExploreASL to BIDS compatibilitybugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions