-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
Labels
featureNew feature, enhancement or requestNew feature, enhancement or request
Milestone
Description
Description
Dcm2nii had a feature to keep track which subjects were or were not yet processed. Currently, it either processes the full population/dataset, or not, which may not be acceptable for large studies. We need to make lock-files for all subjects to make sure all was processed and to enable importing only those that broke previously or that were not yet imported.
- The decision to run a script should be done in the master script or the parent script, and not inside a subscript = the conditions/decision to run a sub-script should happen on the higher level if possible.
- This also requires similar error/warning logging as with the other modules.
Warning: Could not find the StudyPar.json file > In xASL_module_Import (line 145). If I runExploreASL('path'), [1 0 0 0], 0)I don't needstudyPar.jsonright? So this warning and skipping should be in the actual import part that uses thestudyPar.json, not all the way upfront.tempfolder in DCM2BIDS import should be moved toderivatives👍- all lock files for import should be in
derivatives - If
/temporBIDSreport.jsonalready exists, it assumes that thedcm2niipart has successfully ran and continues with the next step, even if you rerun. This is not always appropriate (e.g., whendcm2niicrashed for some reason). Do we need this check subject by subject or scan by scan, rather than on the dataset level? - If you get an error in
BIDSifyASL2JSONline 320, it still removes thetempfolder, which makes debugging difficult. It should only delete thetempfolder when it is empty right? And it can only be empty after successfully moving the data file-by-file torawdata?
Release notes
Required: summarize the changes for the release notes here
Metadata
Metadata
Assignees
Labels
featureNew feature, enhancement or requestNew feature, enhancement or request