Skip to content

Make import a full module #799

@jan-petr

Description

@jan-petr

Description

Dcm2nii had a feature to keep track which subjects were or were not yet processed. Currently, it either processes the full population/dataset, or not, which may not be acceptable for large studies. We need to make lock-files for all subjects to make sure all was processed and to enable importing only those that broke previously or that were not yet imported.

  • The decision to run a script should be done in the master script or the parent script, and not inside a subscript = the conditions/decision to run a sub-script should happen on the higher level if possible.
  • This also requires similar error/warning logging as with the other modules.
  • Warning: Could not find the StudyPar.json file > In xASL_module_Import (line 145). If I run ExploreASL('path'), [1 0 0 0], 0) I don't need studyPar.json right? So this warning and skipping should be in the actual import part that uses the studyPar.json, not all the way upfront.
  • temp folder in DCM2BIDS import should be moved to derivatives 👍
  • all lock files for import should be in derivatives
  • If /temp or BIDSreport.json already exists, it assumes that the dcm2nii part has successfully ran and continues with the next step, even if you rerun. This is not always appropriate (e.g., when dcm2nii crashed for some reason). Do we need this check subject by subject or scan by scan, rather than on the dataset level?
  • If you get an error in BIDSifyASL2JSON line 320, it still removes the temp folder, which makes debugging difficult. It should only delete the temp folder when it is empty right? And it can only be empty after successfully moving the data file-by-file to rawdata?

Release notes

Required: summarize the changes for the release notes here

Metadata

Metadata

Assignees

Labels

featureNew feature, enhancement or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions