Skip to content

Record ExploreASL version on Import #746

@jan-petr

Description

@jan-petr

Description

  • Save ExploreASL version into GeneratedBy in Legacy BIDS-derived data. 👍
  • Save ExploreASL version in Acknowledgement into dataset_description for all BIDS functions ("Imported with ExploreASL 1.8.0") 👍
  • Write a function that takes dataset_description (already loaded from JSON on the input) and looks into the acknowledgment and returns the following information: 👍
    • bImportedExploreASL - was the dataset imported with ExploreASL or not (== did we find the string "Imported with ExploreASL XXX") 👍
    • bImportedSameVersion - true if the version matches exactly the current version (full match with BETA) 👍
    • versionExploreASLBIDS - empty (if above == false), or string with version (excluding the BETA) 👍
    • bImportedBETA - true if BETA version was used -> see above, otherwise false 👍
    • That's a lot of outputs, but the aim is to use them only locally and not save them to x and therefore we will have a simply and nice function the prepares us for all different testing scenarios later. The order of the outputs should be something like proposed above - because we might not need to extract all (we can check with nargout if all need to be extracted). I anticipate that all these above can be useful in some situations. But you can correct me if needed. 👍
  • All this above will be used for possible warnings when working with BIDS data of any origin. Now currently. Working with BIDS data in ExploreASL limits to doing BIDS->Legacy conversion (right?!). 👍
  • So we want to issue the following warnings in BIDS2Legacy - I guess it is pretty obvious which of the outputs above will be used: 👍
    • "BIDS created externally, or with an unknown ExploreASL version" 👍
    • "BIDS created with different ExploreASL version than BIDS->Legacy conversion" 👍
    • "BETA version is being used for data conversion" 👍
    • The question is what to do (what to save to derivatives/GeneratedBy) when a different version is used for DCM->BIDS and BIDS->Legacy. Because then the derivatives might not be perfect and the GeneratedBy field might not be completely reliable. Open question to be probably discussed with Henk as well to see if he has some ideas. @HenkMutsaerts might want to comment on this one...
    • The last parameter - the actual version used for the import - this will be only used later on when we will move some of the quantification steps (scalings) to import. The during the quantification, we will want to know what was the version used for import to either do the quantification the old way (with scalings in quantification), or the new way (with scalings in import). 👍

Release notes

Save ExploreASL version in both BIDS and legacy-derivatives imported data.

Metadata

Metadata

Labels

featureNew feature, enhancement or request

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions